HIVE-29587: Cleanup acid table dir after async drop#6459
Merged
Conversation
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
VenuReddy2103
changed the title
deniskuzZ
reviewed
May 4, 2026
Member
|
thanks for the refactor @VenuReddy2103 , that looks much cleaner |
deniskuzZ
reviewed
May 4, 2026
Member
|
with not in scope for this PR |
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
deniskuzZ
reviewed
May 6, 2026
|
nrg4878
approved these changes
May 6, 2026
Contributor
nrg4878
left a comment
nrg4878
left a comment
There was a problem hiding this comment.
Reviewed the HMS side of changes (thrift + some handler code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a new compaction type(
DEFERRED_CLEANUP). It is used while adding a row to compaction queue table when table is soft deleted.Why are the changes needed?
When drop acid table is followed by drop database cascade operation, the acid table directory itself is never deleted. Hence managed database directory is also never deleted. Orphaned table and database directories remaining indefinitely in the filesystem, leading to potential storage bloat and inconsistencies between HMS metadata and filesystem state
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested manually