Skip to content

HIVE-29619: Hive ACID: Long-running queries on one table shouldn't block cleanup operations on other tables.#6497

Merged
deniskuzZ merged 2 commits into
apache:masterfrom
deniskuzZ:HIVE-29420
May 20, 2026
Merged

HIVE-29619: Hive ACID: Long-running queries on one table shouldn't block cleanup operations on other tables.#6497
deniskuzZ merged 2 commits into
apache:masterfrom
deniskuzZ:HIVE-29420

Conversation

@deniskuzZ
Copy link
Copy Markdown
Member

@deniskuzZ deniskuzZ commented May 18, 2026

What changes were proposed in this pull request?

  1. Restore the skip branch for MH-registered opens in TxnUtils.createValidTxnListForCleaner
  2. Restore MIN_HISTORY_WRITE_ID registration in AcidCompactionService
  3. Enabled DELAYED_CLEANUP when useMinHistoryWriteId is true

Why are the changes needed?

Preserve per-table independence: long-running registered queries on one table shouldn't block cleanups of other tables.

Does this PR introduce any user-facing change?

No

How was this patch tested?

TestCleanerWithMinHistoryWriteId#cleanupNotBlockedByOpenTxnOnAnotherTable

@deniskuzZ deniskuzZ requested a review from kuczoram May 18, 2026 13:26
@deniskuzZ deniskuzZ changed the title HIVE-29420: Addendum: Long-running queries on one table shouldn't block cleanup operations on other tables. HIVE-29420: Hive ACID: Addendum: Long-running queries on one table shouldn't block cleanup operations on other tables. May 18, 2026
@deniskuzZ deniskuzZ changed the title HIVE-29420: Hive ACID: Addendum: Long-running queries on one table shouldn't block cleanup operations on other tables. HIVE-29619: Hive ACID: Long-running queries on one table shouldn't block cleanup operations on other tables. May 19, 2026
@deniskuzZ deniskuzZ closed this May 19, 2026
@deniskuzZ deniskuzZ reopened this May 19, 2026
@deniskuzZ deniskuzZ requested a review from Copilot May 19, 2026 07:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

@kuczoram kuczoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Denys for this fix. It looks good to me.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants