HIVE-21959 Clean up Concatenate and Msck DDL commands#703
Closed
miklosgergely wants to merge 1 commit intoapache:masterfrom
Closed
HIVE-21959 Clean up Concatenate and Msck DDL commands#703miklosgergely wants to merge 1 commit intoapache:masterfrom
miklosgergely wants to merge 1 commit intoapache:masterfrom
Conversation
miklosgergely
force-pushed
the
HIVE-21959
branch
2 times, most recently
from
71d81b2 to
0a9124b
Compare
kgyrtkirk
reviewed
Jul 8, 2019
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java
Outdated
Show resolved
Hide resolved
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java
Show resolved
Hide resolved
Contributor
Author
|
New patch passed the tests, please merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concatenate and Msck DDL use basic data structure implementations instead of their interfaces for variable declaration, like ArrayList instead of List, LinkedHashMap instead of Map, etc. This is due to a lot of similar issues in the code, which needs to be cleaned.
Concatenate also had a non-immutable Desc class, that needs to be transformed into an immutable one. Concatenate operation code should be cut into smaller functions.