HIVE-11417. Move the ReaderImpl and the RecordReaderImpl to the ORC module. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omalley
force-pushed
the
hive-11417
branch
3 times, most recently
from
4729a7f to
dbef3aa
Compare
| * @return bytes read | ||
| * @throws IOException | ||
| */ | ||
| void read(Text txt, int size) throws IOException; |
Contributor
There was a problem hiding this comment.
Is there a minimum supported hadoop version for orc? If we don't support older hadoop version then this shim might not be required.
Contributor
Author
There was a problem hiding this comment.
For now we should stick with what Hive supports. I copied this code directly from Hive's HadoopShims.
omalley
force-pushed
the
hive-11417
branch
4 times, most recently
from
a883376 to
7dbb70f
Compare
by making shims for the row by row reader.
lalinsky
pushed a commit
to exponea/hive
that referenced
this pull request
Jun 1, 2016
MAPR-22759 Hive-1.2.1 : Hive Unable to identify maprfs scheme while a…
kgyrtkirk
added a commit
to kgyrtkirk/hive
that referenced
this pull request
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.