[Task]: hop-gui.bat doesn't start correctly if any of the hop_xxx enviro variables are ugly #2649
Description
What needs to happen?
Migration: https://issues.apache.org/jira/browse/HOP-3878
https://issues.apache.org/jira/browse/HOP-3879
I tried setting my HOP_CONFIG_FOLDER to use my onedrive:
SETX HOP_CONFIG_FOLDER "%ONEDRIVE%\hop-config"
GUI would not launch the JAVA VM.
My onedrive folder path is ugly with both spaces and a dash in the path.
I manually fixed it in the hop-gui by quoting the add:
if not "%HOP_CONFIG_FOLDER%"=="" (
set HOP_OPTIONS=%HOP_OPTIONS% -DHOP_CONFIG_FOLDER="%HOP_CONFIG_FOLDER%"
)
Don't think there would be any harm in quoting ALL these options in the batch/script files, then it would elegantly handle UGLY paths automatically.
This change should also be applied to utilities like hop-encrypt (really any batch/sh script that launches the hop tools)
Issue Priority
Priority: 3
Issue Component
Component: CLI, Component: Hop Config, Component: Hop Gui, Component: Hop Run