[Bug]: Same environment names with different project names

[lucaspouzac]

Apache Hop version?

2.17.0-SNAPSHOT

Java version?

docker image from official repo

Operating system

Windows

What happened?

With the 2.17.0 version, the environement name is correctly filtered by project name. But if we have the same environement name on wo different project, the two environments are added at the default project.

With this conf

{
  "projectsConfig" : {
    "lifecycleEnvironments" : [
      {
        "name" : "DEFAULT - LOCAL",
        "purpose" : "Development",
        "projectName" : "default",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/local/env-variables.json"
        ]
      },
      {
        "name" : "DEFAULT - STAGING",
        "purpose" : "Staging",
        "projectName" : "default",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/staging/env-variables.json"
        ]
      },
      {
        "name" : "DEFAULT-PROD",
        "purpose" : "Production",
        "projectName" : "default",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/production/env-variables.json"
        ]
      },
      {
        "name" : "AD-LOCAL",
        "purpose" : "Development",
        "projectName" : "ad",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/local/env-variables.json"
        ]
      },
      {
        "name" : "AD-STAGING",
        "purpose" : "Staging",
        "projectName" : "ad",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/staging/env-variables.json"
        ]
      },
      {
        "name" : "AD-PROD",
        "purpose" : "Production",
        "projectName" : "ad",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/production/env-variables.json"
        ]
      }
    ]
  }
}

With this conf

{
  "projectsConfig" : {
    "lifecycleEnvironments" : [
      {
        "name" : "LOCAL",
        "purpose" : "Development",
        "projectName" : "default",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/local/env-variables.json"
        ]
      },
      {
        "name" : "STAGING",
        "purpose" : "Staging",
        "projectName" : "default",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/staging/env-variables.json"
        ]
      },
      {
        "name" : "PROD",
        "purpose" : "Production",
        "projectName" : "default",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/production/env-variables.json"
        ]
      },
      {
        "name" : "LOCAL",
        "purpose" : "Development",
        "projectName" : "ad",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/local/env-variables.json"
        ]
      },
      {
        "name" : "STAGING",
        "purpose" : "Staging",
        "projectName" : "ad",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/staging/env-variables.json"
        ]
      },
      {
        "name" : "PROD",
        "purpose" : "Production",
        "projectName" : "ad",
        "configurationFiles" : [
          "${HOP_CONFIG_FOLDER}/environments/production/env-variables.json"
        ]
      }
    ]
  }
}

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui

[bamaer]

environment names need to be unique in Apache Hop. The easiest way to get around this is to use a <PROJECT>-<ENV> naming convention or something similar.

[lucaspouzac]

I understand, but it's a shame. An environment is necessarily associated with a project. The prefix could be managed internally.

[lucaspouzac]

In fact, it might be interesting to have the concept of an environment that is inherited from the default project, because environment could be the same between different projects. But that's another topic ^^

[bamaer]

I'm not pretending it's all perfect, but it is what it is for now.
We have another couple of open tickets for projects and environments, so we'll need to take a closer look at projects and environments in general for one of the next releases.

[lucaspouzac]

No problem, it was just feedback following tests on the snapshot version.

[CarlosJuncher03]

I also support the idea of the environment being related to the project. I can have an environment called 'staging' but for different projects. But today, to avoid errors, I do what was mentioned: project name plus environment.

[leehaut]

This issue appears to be similar to #6348 — both are caused by using the file name as a tab ID.

[sramazzina]

@bamaer I think we need to classify issues like this in a different way just to identify something that works but must/can be reviewed after further discussion. As you correctly said, they are not bug but things that came from a precise decisions we took during Hop development. And like this there are many other. We can tag these issues with something like "candidate for review" or something like this just to remove the type Bug that IMHO is not appropriate.