[Bug]: Hop-config.json does not respect command-line system properties

[jballment]

Apache Hop version?

2.16.0

Java version?

OpenJDK Runtime Environment (build 17+35-2724)

Operating system

Windows

What happened?

Hop-config.json does not respect command-line system properties e.g.

hop-config.json contains:
{
"variables" : [
{
"name" : "MY_TEST",
"value" : "0",
"description" : "My test value"
},

At the command-line (Windows PowerShell) I set:
$Env:HOP_OPTIONS="-Xmx2048m -DMY_TEST=1 -DMY_TEST_2=2"
hop-gui.bat

If I run a simple pipeline to resolve ${MY_TEST) and ${MY_TEST_2}, MY_TEST will equal 0 and MY_TEST_2 will equal 2.

Issue Priority

Priority: 3

Issue Component

Component: CLI

[jballment]

My proposed solution is the check if the described variable already exists as a System property and set the described variable = system property if it does exist:

diff --git a/engine/src/main/java/org/apache/hop/core/HopEnvironment.java b/engine/src/main/java/org/apache/hop/core/HopEnvironment.java
index 71bb0817ea..577e83d88f 100644
--- a/engine/src/main/java/org/apache/hop/core/HopEnvironment.java
+++ b/engine/src/main/java/org/apache/hop/core/HopEnvironment.java
@@ -146,8 +146,12 @@ public class HopEnvironment {
         //
         for (DescribedVariable describedVariable : hopConfig.getDescribedVariables()) {
           if (StringUtils.isNotEmpty(describedVariable.getName())) {
-            System.setProperty(
-                describedVariable.getName(), Const.NVL(describedVariable.getValue(), ""));
+            if (StringUtils.isEmpty(System.getProperty(describedVariable.getName()))) {
+              System.setProperty(
+                  describedVariable.getName(), Const.NVL(describedVariable.getValue(), ""));
+            } else {
+              describedVariable.setValue(System.getProperty(describedVariable.getName()));
+            }
           }
         }