Merged
Conversation
mattcasters
reviewed
Jan 11, 2022
Contributor
mattcasters
left a comment
There was a problem hiding this comment.
Can you reduce the number of closes to 2 for the local pipeline and workflow engines?
Simply put a try {} finally {} block around the commit and rollback.
So:
try { if() { commit() } else { rollback} } finally { close database }
It reduces code duplication.
Also, change the ignoredKde variable. The exception is not ignored, it's logged. So rename to hde. You can remove the comment about not being able to do anything about an exception. That's always the case :-)
// The only exception thrown from closeConnectionOnly()
// cannot do anything about this but log it
Contributor
Author
|
Ok Matt thanks for reviewing |
mattcasters
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.