Skip to content

HOP-3673#1268

Merged
mattcasters merged 3 commits intoapache:masterfrom
sramazzina:COMMIT-MISSING
Jan 12, 2022
Merged

HOP-3673#1268
mattcasters merged 3 commits intoapache:masterfrom
sramazzina:COMMIT-MISSING

Conversation

@sramazzina
Copy link
Contributor

No description provided.

Copy link
Contributor

@mattcasters mattcasters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reduce the number of closes to 2 for the local pipeline and workflow engines?
Simply put a try {} finally {} block around the commit and rollback.
So:
try { if() { commit() } else { rollback} } finally { close database }

It reduces code duplication.

Also, change the ignoredKde variable. The exception is not ignored, it's logged. So rename to hde. You can remove the comment about not being able to do anything about an exception. That's always the case :-)

// The only exception thrown from closeConnectionOnly()
// cannot do anything about this but log it

@sramazzina
Copy link
Contributor Author

Ok Matt thanks for reviewing

@mattcasters mattcasters merged commit 993a960 into apache:master Jan 12, 2022
@sramazzina sramazzina deleted the COMMIT-MISSING branch April 28, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants