Skip to content

HOP-3826, HOP-3988#1529

Merged
hansva merged 2 commits intoapache:masterfrom
nadment:HOP-3826
Jun 10, 2022
Merged

HOP-3826, HOP-3988#1529
hansva merged 2 commits intoapache:masterfrom
nadment:HOP-3826

Conversation

@nadment
Copy link
Contributor

@nadment nadment commented Jun 7, 2022

No description provided.

@uraychang
Copy link
Contributor

hi @nadment, is HopGuiEvents.ProjectUpdated used somewhere else?
I saw HopGuiEvents.ProjectActivated was triggered when enabling the project.
but is adding HopGuiEvents.ProjectUpdated listener necessary?

@nadment
Copy link
Contributor Author

nadment commented Jun 9, 2022

You are right @uraychang , HopGuiEvents.ProjectUpdate is never triggered, but it should be when editing a project path.
https://issues.apache.org/jira/browse/HOP-3988

@nadment nadment changed the title HOP-3826 Refresh File Explorer on project change or activated HOP-3826, HOP-3988 Jun 9, 2022
@uraychang uraychang closed this Jun 10, 2022
@uraychang uraychang reopened this Jun 10, 2022
Copy link
Contributor

@uraychang uraychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadment great work!
sorry I misclick the close button...

@hansva hansva merged commit 054b0d4 into apache:master Jun 10, 2022
@nadment nadment deleted the HOP-3826 branch May 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants