(DOC) - HTTP CLIENT Documentation Table Typo Fix#1585
Merged
hansva merged 1 commit intoapache:release2.0.0from Jul 13, 2022
Merged
(DOC) - HTTP CLIENT Documentation Table Typo Fix#1585hansva merged 1 commit intoapache:release2.0.0from
hansva merged 1 commit intoapache:release2.0.0from
Conversation
https://hop.apache.org/manual/latest/pipeline/transforms/http.html#_description When viewing in a browser, on the documentation page for the HTTP Client, the text in the rows for the columns Option and Description begin to get mixed up at "Connection Close wait time", which results in a a mishmash where Option text is in Description and they don't align correctly moving down the table. For example, the last row displays as Option: Area where you define the parameter name-value pairs to pass on the URL | Description: Custom HTTP Headers. It seems there was a missing "|" (vertical bar) on line 45 after "Connection Close wait time". By adding the vertical bar there, the rest of the values in the table will be aligned in their correct columns.
Contributor
|
Thanks, I will merge it towards its base branch (release2.0.0) and cherry-pick to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[HOP-XXX] - Fixes bug in SessionManager,where you replace
HOP-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the commit message.
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like
(DOC) - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.