Skip to content

Comments

HOP-3398#1588

Merged
hansva merged 3 commits intoapache:masterfrom
sramazzina:HOP-3398
Jul 14, 2022
Merged

HOP-3398#1588
hansva merged 3 commits intoapache:masterfrom
sramazzina:HOP-3398

Conversation

@sramazzina
Copy link
Contributor

@sramazzina sramazzina commented Jul 13, 2022

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [HOP-XXX] - Fixes bug in SessionManager,
    where you replace HOP-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hansva
Copy link
Contributor

hansva commented Jul 14, 2022

I'm going to add tests made with the "old" version before merging this, then we know we have no regression errors

@hansva hansva self-assigned this Jul 14, 2022
@sramazzina
Copy link
Contributor Author

sramazzina commented Jul 14, 2022

I agree wth you, my apologizes for not thinking about that. I have a file made with previous version that I used to test the changes. I can add that for you if you didn't started your yet.

HOP-3398: fix MDI and code cleanup
@hansva hansva merged commit fcc5b43 into apache:master Jul 14, 2022
@sramazzina sramazzina deleted the HOP-3398 branch December 29, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants