Skip to content

Fixing Sonar Blockers in plugins/transforms/snowflake#1621

Merged
hansva merged 1 commit into
apache:masterfrom
rohitvvv:master
Aug 8, 2022
Merged

Fixing Sonar Blockers in plugins/transforms/snowflake#1621
hansva merged 1 commit into
apache:masterfrom
rohitvvv:master

Conversation

@rohitvvv
Copy link
Copy Markdown
Contributor

@rohitvvv rohitvvv commented Aug 6, 2022

Adding try resource to sonar reported files.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [HOP-XXX] - Fixes bug in SessionManager,
    where you replace HOP-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@rohitvvv rohitvvv changed the title Fixing Sonar Blockers Fixing Sonar Blockers in plugins/transforms/snowflake Aug 6, 2022
@hansva
Copy link
Copy Markdown
Contributor

hansva commented Aug 8, 2022

Thank you for cleaning this up!

Adding try resource to sonar reported files.
@rohitvvv
Copy link
Copy Markdown
Contributor Author

rohitvvv commented Aug 8, 2022

Updated the build issues. The commit builds fine now.

@hansva hansva merged commit ef6708d into apache:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants