Skip to content

fix #3432#3435

Closed
sramazzina wants to merge 2 commits intoapache:masterfrom
sramazzina:3432
Closed

fix #3432#3435
sramazzina wants to merge 2 commits intoapache:masterfrom
sramazzina:3432

Conversation

@sramazzina
Copy link
Contributor

@sramazzina sramazzina commented Nov 20, 2023

fix #3432 Error Handling Settings Unavailable in Dimension Lookup/Update


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hansva
Copy link
Contributor

hansva commented Nov 22, 2023

@sramazzina

The dimensionLookupUpdate has no error handling so setting that value to true is incorrect.
Nowhere in the code is the putError method used to put rows in the error handling.

@hansva hansva closed this Nov 22, 2023
@sramazzina
Copy link
Contributor Author

sramazzina commented Nov 22, 2023

Thanks for providing the info and excuse me for my error. I will apply this change and will be back with the fix. Grazie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error Handling Settings Unavailable in Dimension Lookup/Update Step

2 participants