Fix #6109, Fix #6107, Fix #6118 #6117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Decided to add some tests before considering the PR completed |
…or every result row
Contributor
Author
|
Added integrations tests. PR is completed |
Contributor
|
This fix re-introduced the original problem |
Contributor
|
I added a reproduction path for the original issue |
Contributor
|
Thanks Hans, I was about to ask if you could share it!
…On Sun, 7 Dec 2025 at 13:24, Hans Van Akelyen ***@***.***> wrote:
*hansva* left a comment (apache/hop#6117)
<#6117 (comment)>
I added a reproduction path for the original issue
—
Reply to this email directly, view it on GitHub
<#6117 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD6Z6HX3XMXRDRBNG6S5UD4AQL77AVCNFSM6AAAAACN7C3EICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMRRHE3TANZQHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
Thank you @hansva for providing a reproduction case of your original issue. We will have a look. Let me put the PR in draft up until the issue won't be solver |
Contributor
Author
|
Issue definitely solved. Tested both with your integration test and mine for regressions. |
xdelox
pushed a commit
to SeraSoft/hop
that referenced
this pull request
Dec 12, 2025
* Fix apache#6109, Fix apache#6107 * Fix apache#6118 Action Pipeline - add integration tests for execute for every result row * Add test case for copy rows to result failure * Fixed issue related to rows' duplication --------- Co-authored-by: Hans Van Akelyen <hans.van.akelyen@gmail.com> (cherry picked from commit 44dc880)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6109
fix #6107
fix #6118
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.