Fix#6754 incorrect date truncation logic in JavaScript transform truncDate#6759
Merged
mattcasters merged 3 commits intoapache:mainfrom Mar 11, 2026
Merged
Fix#6754 incorrect date truncation logic in JavaScript transform truncDate#6759mattcasters merged 3 commits intoapache:mainfrom
mattcasters merged 3 commits intoapache:mainfrom
Conversation
Signed-off-by: lance <leehaut@gmail.com>
Contributor
|
Can you confirm that we now implemented the other options, truncation levels, correctly and that previous functionality still works as is? It would be amazing if we had an extra integration test to show this. |
Contributor
Author
I verified this through the |
Signed-off-by: lance <leehaut@gmail.com>
Signed-off-by: lance <leehaut@gmail.com>
Contributor
Author
|
Add integration test for |
Contributor
|
Thanks @leehaut, great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6754 -- JavaScript transform plugin truncDate functionality changed and does not match documentation
This PR fixes an issue in the
truncDateimplementation used by the JavaScript transform.The previous implementation only reset the specific time field for the requested truncation