Skip to content

Fix#6959 Unable to open transform selection dialog via left-click in Hop GUI Pipeline #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattcasters merged 1 commit into from
Apr 5, 2026
+5 −3
Merged

Fix#6959 Unable to open transform selection dialog via left-click in Hop GUI Pipeline #6960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...sting/src/main/java/org/apache/hop/testing/xp/LocationMouseDoubleClickExtensionPoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ public void callExtensionPoint(
throws HopException {
HopGuiPipelineGraph pipelineGraph = pipelineGraphExtension.getPipelineGraph();
PipelineMeta pipelineMeta = pipelineGraph.getPipelineMeta();
pipelineGraphExtension.setPreventingDefault(true);

PipelineUnitTest unitTest = TestingGuiPlugin.getCurrentUnitTest(pipelineMeta);
if (unitTest == null) {
Expand All @@ -81,7 +80,7 @@ public void callExtensionPoint(
}
}

// Find the location that was double clicked on...
// Find the location that was double-clicked on...
//
MouseEvent e = pipelineGraphExtension.getEvent();
Point point = pipelineGraphExtension.getPoint();
Expand All @@ -93,12 +92,13 @@ public void callExtensionPoint(
//
if (DataSetConst.AREA_DRAWN_INPUT_DATA_SET.equals(areaOwner.getParent())) {

// Open the dataset double clicked on...
// Open the dataset double-clicked on...
//
String transformName = (String) areaOwner.getOwner();

PipelineUnitTestSetLocation inputLocation = unitTest.findInputLocation(transformName);
if (inputLocation != null) {
pipelineGraphExtension.setPreventingDefault(true);
PipelineUnitTestSetLocationDialog dialog =
new PipelineUnitTestSetLocationDialog(
hopGui.getActiveShell(),
Expand All @@ -120,6 +120,7 @@ public void callExtensionPoint(

PipelineUnitTestSetLocation goldenLocation = unitTest.findGoldenLocation(transformName);
if (goldenLocation != null) {
pipelineGraphExtension.setPreventingDefault(true);
PipelineUnitTestSetLocationDialog dialog =
new PipelineUnitTestSetLocationDialog(
hopGui.getActiveShell(),
Expand Down Expand Up @@ -157,6 +158,7 @@ public void callExtensionPoint(
return;
}

pipelineGraphExtension.setPreventingDefault(true);
ValidatePipelineUnitTestExtensionPoint.showUnitTestErrors(pipeline, results, hopGui);
}
}
Expand Down
Loading