HOP-7045 [Bug]: Default values overwrite empty fields in TextFileOutput#7079
Closed
fskorgen wants to merge 1 commit into
Closed
HOP-7045 [Bug]: Default values overwrite empty fields in TextFileOutput#7079fskorgen wants to merge 1 commit into
fskorgen wants to merge 1 commit into
Conversation
Contributor
|
This will be a broader issue caused by the deserialization changes introduced, while this fix solves the issue for textfileOutput the same issue might be present in other spots. I am looking at a global fix. |
Contributor
|
should be fixed with #7087 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved setting of default values for separator and enclosure from constructor to setDefault
Empty values are now accepted instead of being overridden by defaults
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.