issue #7338 : Pipeline fails to open error-handling hop#7360
Merged
Conversation
… references a non-existent transform (misleading TransformErrorMeta error)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walkthrough - XML Deserialization Lookup Graceful Failure (Issue 7338)
We fixed an issue where loading a pipeline XML file failed with a fatal exception if an error-handling configuration referenced a target transform name that no longer exists in the pipeline (or was deleted). We changed the deserialization process to handle missing references gracefully.
Changes Made
Core Metadata Serialization
deSerializeXmlUsingNamedList(...), removed the throwing ofHopXmlExceptionwhen a referenced object name (e.g., in a named list such astransformsorworkflowActions) cannot be found.null, allowing the deserialization of the parent object to finish successfully, setting the missing reference field tonull.Core Engine Tests
testIssue7338()to PipelineMetaTest.java:NonExistentTransform.nullwithout throwing a fatal deserialization error.Verification & Testing
Compilation & Tests
coreandenginemodules, with all 584 tests passing successfully:./mvnw test -pl core,engine