Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

feat: add benchmarks for encoding#1613

Merged
jiacai2050 merged 4 commits intoapache:mainfrom
zealchen:feat_benchmark
Dec 18, 2024
Merged

feat: add benchmarks for encoding#1613
jiacai2050 merged 4 commits intoapache:mainfrom
zealchen:feat_benchmark

Conversation

@zealchen
Copy link
Contributor

Rationale

#1600

Detailed Changes

Additional benchmarks for this issue

Test Plan

Append 100 new delta sstfiles to snapshot with 1000 records.

Benchmarking bench_encoding/new_format_encoding/0: Collecting 10 samples in estimated 5.0005 s (494k iterations)
bench_encoding/new_format_encoding/0
                        time:   [10.232 µs 10.611 µs 10.900 µs]
                        change: [-1.5176% +2.1745% +5.9315%] (p = 0.30 > 0.05)
                        No change in performance detected.

@jiacai2050 jiacai2050 changed the title feat add benchmarks for encoding feat: add benchmarks for encoding Dec 18, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 18, 2024
@jiacai2050 jiacai2050 self-requested a review December 18, 2024 06:55
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 55dcabe into apache:main Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants