This repository was archived by the owner on Mar 12, 2026. It is now read-only.
refactor: remove async remote write decode logic#1631
Merged
jiacai2050 merged 1 commit intoapache:mainfrom Dec 11, 2025
Merged
Conversation
jiacai2050
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Deserialization is a CPU-intensive task, so introducing async does not provide significant benefits. In addition, using async causes function contagion issues. Therefore, it is necessary to remove the async decode logic.
Detailed Changes
decode_asyncinterfacedeadpooltoobject-poolTest Plan
Manual test