Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

chore: normalize http api#659

Merged
ShiKaiWi merged 1 commit intoapache:mainfrom
jiacai2050:chore-http-api
Feb 24, 2023
Merged

chore: normalize http api#659
ShiKaiWi merged 1 commit intoapache:mainfrom
jiacai2050:chore-http-api

Conversation

@jiacai2050
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Make

  • All internal apis begin with debug
  • Admin related apis begin with admin

What changes are included in this PR?

Are there any user-facing changes?

Yes

How does this change test

No need

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #659 (d4a6b04) into main (3865c1b) will decrease coverage by 0.02%.
The diff coverage is 10.71%.

❗ Current head d4a6b04 differs from pull request most recent head 741e219. Consider uploading reports for the commit 741e219 to get more accurate results

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
- Coverage   66.95%   66.94%   -0.02%     
==========================================
  Files         283      283              
  Lines       43969    43969              
==========================================
- Hits        29441    29436       -5     
- Misses      14528    14533       +5     
Impacted Files Coverage Δ
...ry_engine/src/logical_optimizer/type_conversion.rs 90.25% <ø> (ø)
server/src/config.rs 37.20% <0.00%> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
analytic_engine/src/sst/parquet/meta_data.rs 83.61% <100.00%> (ø)
sql/src/planner.rs 93.83% <100.00%> (ø)
components/skiplist/src/list.rs 98.87% <0.00%> (-0.46%) ⬇️
common_types/src/column.rs 61.03% <0.00%> (-0.28%) ⬇️
analytic_engine/src/instance/write_worker.rs 71.81% <0.00%> (-0.20%) ⬇️
analytic_engine/src/row_iter/merge.rs 88.58% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread server/src/http.rs
Copy link
Copy Markdown
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 24, 2023
Merged via the queue into apache:main with commit 9e06dcc Feb 24, 2023
@jiacai2050 jiacai2050 deleted the chore-http-api branch February 24, 2023 09:14
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants