Skip to content

Conversation

@Rachelint
Copy link
Contributor

@Rachelint Rachelint commented May 22, 2023

Related Issues

Closes #

Detailed Changes

  • Add console subcriber to tracing.
  • Add related configs to decide whether open with tokio console server.
  • Modify makefile to support build with unstable tokio.

Test Plan

Test manually.

@Rachelint Rachelint force-pushed the support-tokio-console branch from e45936c to 732c13c Compare May 22, 2023 09:31
@Rachelint Rachelint force-pushed the support-tokio-console branch from 732c13c to db70903 Compare May 22, 2023 09:32
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 8893478 into apache:main May 22, 2023
@Rachelint Rachelint deleted the support-tokio-console branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants