Skip to content

4.5.x (org.apache.http.impl.client)HttpRequestTaskCallable#102

Closed
chenying99 wants to merge 204 commits intomasterfrom
4.5.x
Closed

4.5.x (org.apache.http.impl.client)HttpRequestTaskCallable#102
chenying99 wants to merge 204 commits intomasterfrom
4.5.x

Conversation

@chenying99
Copy link

            metrics.getRequests().increment(started);
            metrics.getTasks().increment(started);//这里应该是scheduled
            metrics.getActiveConnections().decrementAndGet();

line 106, "started" should be "scheduled"?
yes or no?

ok2c and others added 30 commits May 24, 2015 13:01
… instance only if credentials are explicitly set

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1681815 13f79535-47bb-0310-9956-ffa450edef68
Contributed by Andrey Pohilko <apc4 at ya.ru>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1682040 13f79535-47bb-0310-9956-ffa450edef68
Contributed by Dmitry Potapov <dpotapov at yandex-team.ru>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1683475 13f79535-47bb-0310-9956-ffa450edef68
…en creating UrlEncodedFormEntity

Contributed by Sergey Smith <smithsv at bk.ru>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1692404 13f79535-47bb-0310-9956-ffa450edef68
and add test that proves that it's not necessary.
Mostly provide bones of future OSGi tests.

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696142 13f79535-47bb-0310-9956-ffa450edef68
…jects, not Strings

Deprecate constructors using String-based passwords

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x@1696576 13f79535-47bb-0310-9956-ffa450edef68
ok2c and others added 12 commits July 4, 2018 14:40
…or connection based authentication schemes (such as NTLM)
…nt Fluent, HttpClient Windows and HttpClient Cache
HttpClient 4.5.4 modified BasicCookieStore to introduce a new
ReadWriteLock field to improve performance. Unfortunately this
also changed the serialized data structure, and any objects
serialized using HttpClient 4.5.3 and before would be unusable
after restore in HttpClient 4.5.4 due to the new "lock" field
being null.

The fix is to change "lock" to be transient, and ensure it is
correctly instantiated upon object restore. This restores
compatibility with HttpClient 4.5.3, as well as maintaining
compatible with the intermediate versions containing the
regression. This also avoids unnecessary serialization of
the new "lock" field, which does not need to be persisted.
…meoutException as ConnectTimeoutException for consistency with non-deprecated code
- Add missing serial version ID (default 1L)
- Camel-case names.
- Don't nest in else clause unnecessarily.
- Remove declared exceptions that are not thrown (but don't break BC.)
- Remove redundant superinterface
- Access static methods directly
- Better local var names.
@ok2c
Copy link
Member

ok2c commented Aug 30, 2018

@chenying99 Please close this PR.

@perlun
Copy link

perlun commented Nov 6, 2018

@chenying99 seems to have left the building. @ok2c, could you just close it perhaps?

@ok2c
Copy link
Member

ok2c commented Nov 6, 2018

@perlun Sadly, I cant. I have read only access to the project hosted at GitHub. Only select folks at ASF Infra can do that.

@perlun
Copy link

perlun commented Nov 7, 2018

@ok2c

@perlun Sadly, I cant. I have read only access to the project hosted at GitHub. Only select folks at ASF Infra can do that.

I see. Maybe @sebbASF has access or know someone who has?

@ok2c
Copy link
Member

ok2c commented Nov 8, 2018

@perlun I seriously doubt he would care. The right way to deal with the problem is to raise a JIRA with ASF Infra and kindly ask them to close the PR for us (and a few others).

@perlun
Copy link

perlun commented Nov 13, 2018

@ok2c

The right way to deal with the problem is to raise a JIRA with ASF Infra and kindly ask them to close the PR for us (and a few others).

Makes sense. Feel free to do it, I'm just a (mostly) innocent bystander. 😇

@ok2c ok2c closed this Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.