Overload Request's execute method to allow custom CloseableHttpClient #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It's a really minor improvement. The idea is to enable a user to specify a custom client to execute fluent Requests with. The final goal in my case is to being able to change the KeepAlivePolicy easily, without using a custom Executor.
I will explain my specific case now. We build a lib which uses fluent Requests. Everything was working fine, but at some point we changed our firewall setup. The firewall is killing open connections (which are, obviously, not transmitting data) without warning after an hour. By default, the keep alive policy used by HttpClient permits connections to stay alive forever. We need to change that. However, we built some code around the fluent api already, adding a custom executor in there wouldn't be trivial.
I guess there is other cases where a custom client could be helpful.
If I missed something, like another way to set a keepAlivePolicy on a fluent Request, please tell me.