Skip to content

Conversation

@MYDIH
Copy link

@MYDIH MYDIH commented Aug 29, 2018

Hi,

It's a really minor improvement. The idea is to enable a user to specify a custom client to execute fluent Requests with. The final goal in my case is to being able to change the KeepAlivePolicy easily, without using a custom Executor.

I will explain my specific case now. We build a lib which uses fluent Requests. Everything was working fine, but at some point we changed our firewall setup. The firewall is killing open connections (which are, obviously, not transmitting data) without warning after an hour. By default, the keep alive policy used by HttpClient permits connections to stay alive forever. We need to change that. However, we built some code around the fluent api already, adding a custom executor in there wouldn't be trivial.

I guess there is other cases where a custom client could be helpful.

If I missed something, like another way to set a keepAlivePolicy on a fluent Request, please tell me.

@ok2c
Copy link
Member

ok2c commented Aug 30, 2018

Committed to maser as 6e76a8b. Please review and close.

@MYDIH MYDIH closed this Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants