HTTPCLIENT-1969: Filter out weak cipher suites#140
HTTPCLIENT-1969: Filter out weak cipher suites#140ok2c merged 1 commit intoapache:4.5.xfrom artem-smotrakov:filter-weak-ciphers
Conversation
httpclient/src/main/java/org/apache/http/conn/ssl/SSLConnectionSocketFactory.java
Outdated
Show resolved
Hide resolved
garydgregory
left a comment
There was a problem hiding this comment.
I like the idea of this patch!
ok2c
left a comment
There was a problem hiding this comment.
@artem-smotrakov Please normalize cipher names prior to doing the weak algo matching.
|
Addressed comments from @ok2c
Please take a look. |
ok2c
left a comment
There was a problem hiding this comment.
@artem-smotrakov Almost there. See my comment. Please also squash commits into a single one.
httpclient/src/main/java/org/apache/http/conn/ssl/SSLConnectionSocketFactory.java
Outdated
Show resolved
Hide resolved
|
Updated the patch:
@ok2c Please take a look. |
ok2c
left a comment
There was a problem hiding this comment.
@artem-smotrakov So much nicer, is it not?
|
@artem-smotrakov Would you also be willing to port this change-set to |
|
To be honest, I am not convinced that regexp is better here, but it's not a big deal to me :) Let's agree to disagree, you have more experience with this project :) Sure, I'll port it to the master branch. Thanks for the review @ok2c ! |
Please consider a patch for HTTPCLIENT-1969:
SSLConnectionSocketFactoryto filter out weak ciphers if cipher suites are not explicitly set.Please note that the test passes with latest Java versions even without patching
SSLConnectionSocketFactorybecause latest Java versions disable weak ciphers by default. The filtering mechanism blocks weak ciphers in case older Java versions are used.