Merged
Conversation
Member
|
@rhernandez35 Thank you for contributing this PR. It would really cool if you could make similar changes to the config classes in HttpCore. |
Contributor
|
@ok2c Do you agree with his suggestion that the Javadoc should be moved to the builder methods? I like that idea. |
Member
|
@rschmitt I am fine with it as long as the same change get applied consistently to all similar classes in core and client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I linked each builder method to its corresponding getter in the built object. However, the builder methods are the primary interface for users, so I think it should hold the primary javadocs instead.