Rename CookieSpecs enum to StandardCookieSpec final class#197
Closed
Rename CookieSpecs enum to StandardCookieSpec final class#197
Conversation
Modeled after StandardCharsets, the new class indicates a non-exhaustive list of standard cookie specifications by name supported by the HttpClient. The previous enum suffered from two issues: * it was exhaustive implying that no more cookie specifications can be supported * its sole purpose was to contain an id for the declared cookie specification; the enum values theirselves were never used directly This also reuses the naming approach of HttpMultipartMode of symbolic names for implementation behavior. This closes #197
ok2c
reviewed
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modeled after StandardCharsets, the new class indicates a non-exhaustive
list of standard cookie specifications by name supported by the HttpClient.
The previous enum suffered from two issues:
the enum values theirselves were never used directly
@ok2c This also reuses the naming approach of HttpMultipartMode of symbolic names for
implementation behavior.
This closes #197