Skip to content

Build requests from method names #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garydgregory merged 1 commit into from
Jan 28, 2020
Merged

Build requests from method names #204

garydgregory merged 1 commit into from
Jan 28, 2020

Conversation

@garydgregory
Copy link
Member

@garydgregory garydgregory commented Jan 28, 2020

Now that ClassicHttpRequests is no longer an enum, I need to way to generically build requests from method names.

@garydgregory
Now that ClassicHttpRequests is no longer an enum, I need to way to
d397845 
generically build requests from method names.
@michael-o
Copy link
Member

michael-o commented Jan 28, 2020

Will look at it later...

@ok2c
Copy link
Member

ok2c commented Jan 28, 2020

@garydgregory @michael-o Please make symmetric changes to BasicHttpRequests and SimpleHttpRequests.

@michael-o michael-o self-requested a review January 28, 2020 17:06
@garydgregory
Copy link
Member Author

garydgregory commented Jan 28, 2020

@garydgregory @michael-o Please make symmetric changes to BasicHttpRequests and SimpleHttpRequests.

I'll do that in a separate PR now that @michael-o has approved this one.

@garydgregory garydgregory merged commit 776ecda into apache:master Jan 28, 2020
asfgit pushed a commit that referenced this pull request Jan 28, 2020
@garydgregory
Build requests from method names in ClassicHttpRequests #204.
ca61e60
@ok2c
Copy link
Member

ok2c commented Jan 28, 2020

@garydgregory Why? Why separate PR?

@garydgregory
Copy link
Member Author

garydgregory commented Jan 28, 2020

@garydgregory Why? Why separate PR?

@michael-o had approved the PR. I feel it is nicer not to ask a reviewer to look at the same code again

@ok2c
Copy link
Member

ok2c commented Jan 28, 2020

@garydgregory It was nicer to merge half-baked change-set? How so? The reviewer might still need to look at the remaining changes before the entire change-set gets merged.

asfgit pushed a commit that referenced this pull request Jan 28, 2020
@garydgregory @ok2c
Now that ClassicHttpRequests is no longer an enum, we need to way to
95dbbf0 
generically build requests from method names. Update all factory classes
with matching APIs for Method and String method name inputs.

(#204), (#205)
garydgregory added a commit to garydgregory/httpcomponents-client that referenced this pull request Jan 29, 2020
@garydgregory
Build requests from method names in ClassicHttpRequests apache#204.
3f60d7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garydgregory @michael-o @ok2c