PoolingAsyncClientConnectionManager handles null ping callback values #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive reference equality
This change brings back handling for null values that was lost in the fix for HTTPCLIENT-2097. Note that unlike the previous implementation, a null value results in the connection being discarded and closed as opposed to being added to the pool in an unknown state.
Member
|
@carterkozak Superseded by 93e3d0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings back handling for null values that was lost
in the fix for HTTPCLIENT-2097.
Note that unlike the previous implementation, a null value
results in the connection being discarded and closed as opposed to
being added to the pool in an unknown state.