HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSLConnectionSocketFactory no longer overrides the socket timeout with the connect timeout when an unlimited socket timeout is configured. This matches behavior of HTTPCLIENT-2091. Note that in scenarios where SocketConfig sets an infinite timeout and the RequestConfig sets a bounded timeout, this change results in the connect-timeout no longer applying to the TLS handshake. This behavior can be retained by setting the expected timeout in the SocketConfig.
Member
|
@carterkozak Damn, the pull request was against master, not the 5.1.x branch. I will have to move it to the 5.1.x branch. |
Contributor
Author
|
oops, my fault, sorry about that. I can set up a revert pr and a second change if you like. |
Member
|
@carterkozak No, worries. I will fix it. |
Member
|
@carterkozak I apologize for causing such a confusion. I was just being old and stupid. HTTPCLIENT-2091 fix committed to master and not 5.1.x. So, we are all good. |
Contributor
Author
|
Not a problem, thanks again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSLConnectionSocketFactory no longer overrides the socket timeout
with the connect timeout when an unlimited socket timeout is
configured. This matches behavior of HTTPCLIENT-2091.
Note that in scenarios where SocketConfig sets an infinite timeout
and the RequestConfig sets a bounded timeout, this change results
in the connect-timeout no longer applying to the TLS handshake.
This behavior can be retained by setting the expected timeout in
the SocketConfig.