Skip to content

Master try w res and more#270

Merged
garydgregory merged 6 commits intoapache:masterfrom
garydgregory:master_try_w_res_and_more
Nov 24, 2020
Merged

Master try w res and more#270
garydgregory merged 6 commits intoapache:masterfrom
garydgregory:master_try_w_res_and_more

Conversation

@garydgregory
Copy link
Copy Markdown
Member

@garydgregory garydgregory commented Nov 23, 2020 •
edited
Loading

Each commit in this PR comprise one kind of cleanup/change:

  • Use try-with-resources.
  • Use Arrays.fill().
  • Add missing @OverRide.
  • Simplify if/else.
  • Remove redundant modifiers. …
  • Remove redundant returns.

michael-o
michael-o requested changes Nov 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@garydgregory
Copy link
Copy Markdown
Member Author

garydgregory commented Nov 23, 2020

Please rebase

Oops, will do. TY.

@garydgregory
Use try-with-resources.
a00346b
@garydgregory
Use Arrays.fill().
77e9180
@garydgregory
Add missing @OverRide.
9d7f745
@garydgregory
Simplify if/else.
57e2e0a
@garydgregory
Remove redundant modifiers.
1213edc 
- All methods in a final class are already final.
- All members of an interface are public.
- All inner enums are static.
@garydgregory
Remove redundant returns.
e9651f3
@garydgregory garydgregory force-pushed the master_try_w_res_and_more branch from e7f81ea to e9651f3 Compare November 24, 2020 00:21
@garydgregory
Copy link
Copy Markdown
Member Author

garydgregory commented Nov 24, 2020

Please rebase

Oops, will do. TY.

Done.

@garydgregory garydgregory merged commit 75f9ade into apache:master Nov 24, 2020
asfgit pushed a commit that referenced this pull request Nov 24, 2020
@garydgregory
Document PR #270: Master try w res and more.
51e2647
asfgit pushed a commit that referenced this pull request Nov 24, 2020
@garydgregory @ok2c
Document PR #270: Master try w res and more.
f5639a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garydgregory @michael-o