Fix the issues causing Kerberos/SPNego to fail #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
careylam
commented
Feb 20, 2021
careylam
commented
- At the beginning of the negotiate, no token is defined in "WWW-Authenticate: Negotiate".
- Kerberos expects HTTP.
1. At the beginning of the negotiate, no token is defined in "WWW-Authenticate: Negotiate". 2. Kerberos expects HTTP.
michael-o
reviewed
Feb 20, 2021
| private static final Logger LOG = LoggerFactory.getLogger(GGSSchemeBase.class); | ||
|
|
||
| private static final String NO_TOKEN = ""; | ||
| private static final String KERBEROS_SCHEME = "HTTP"; |
Member
There was a problem hiding this comment.
This name is semantically wrong! It is a service class and not a Kerberos scheme. I also don't understand why make a difference between null and #isEmpty() with a static final field.
Member
|
@michael-o Just tweak the commit and force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.