Merged
Conversation
arturobernalg
force-pushed
the
feature/typos_other
branch
from
0bb5fc5 to
cb1956f
Compare
michael-o
reviewed
Oct 17, 2021
| private boolean from1_0Origin(final HttpResponse response) { | ||
| final Iterator<HeaderElement> it = MessageSupport.iterate(response, HeaderConstants.VIA); | ||
| while (it.hasNext()) { | ||
| if (it.hasNext()) { |
Member
Author
There was a problem hiding this comment.
because it doesn't iterate. in the best case it returns the protocol
Member
There was a problem hiding this comment.
because it doesn't iterate. in the best case it returns the protocol
@arturobernalg This is true but is it really worth it?
Member
There was a problem hiding this comment.
@arturobernalg Especially mixed into a change-set that fixes typos.
* Use java array declarations instead of "c" way.
arturobernalg
force-pushed
the
feature/typos_other
branch
from
4f6ad84 to
b17d227
Compare
Member
Author
|
HI @ok2c @michael-o |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.