Skip to content

Cache request line in HttpRequestWrapper #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hirthwork wants to merge 1 commit into from
Closed

Cache request line in HttpRequestWrapper #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public class HttpRequestWrapper extends AbstractHttpMessage implements HttpUriRe
private final HttpRequest original;
private final HttpHost target;
private final String method;
private RequestLine cachedRequestLine = null;
private ProtocolVersion version;
private URI uri;

Expand All @@ -80,6 +81,7 @@ public ProtocolVersion getProtocolVersion() {

public void setProtocolVersion(final ProtocolVersion version) {
this.version = version;
this.cachedRequestLine = null;
}

@Override
Expand All @@ -89,6 +91,7 @@ public URI getURI() {

public void setURI(final URI uri) {
this.uri = uri;
this.cachedRequestLine = null;
}

@Override
Expand All @@ -108,16 +111,19 @@ public boolean isAborted() {

@Override
public RequestLine getRequestLine() {
String requestUri = null;
if (this.uri != null) {
requestUri = this.uri.toASCIIString();
} else {
requestUri = this.original.getRequestLine().getUri();
}
if (requestUri == null || requestUri.isEmpty()) {
requestUri = "/";
if (this.cachedRequestLine == null) {
String requestUri = null;
if (this.uri != null) {
requestUri = this.uri.toASCIIString();
} else {
requestUri = this.original.getRequestLine().getUri();
}
if (requestUri == null || requestUri.isEmpty()) {
requestUri = "/";
}
this.cachedRequestLine = new BasicRequestLine(this.method, requestUri, getProtocolVersion());
}
return new BasicRequestLine(this.method, requestUri, getProtocolVersion());
return this.cachedRequestLine;
}

public HttpRequest getOriginal() {
Expand Down