Httpclient-2194 async retries not including body#343
Merged
ok2c merged 2 commits intoapache:5.1.xfrom Jan 5, 2022
JasonMathison:HTTPCLIENT-2194_Async_retries_not_including_body
Merged
Httpclient-2194 async retries not including body#343ok2c merged 2 commits intoapache:5.1.xfrom JasonMathison:HTTPCLIENT-2194_Async_retries_not_including_body
ok2c merged 2 commits intoapache:5.1.xfrom
JasonMathison:HTTPCLIENT-2194_Async_retries_not_including_body
Conversation
When applicable call entityProducer.releaseResources() so that on the retry the body will be set.
ok2c
requested changes
Jan 5, 2022
| public void completed() { | ||
| if (state.retrying) { | ||
| scope.execCount.incrementAndGet(); | ||
| if (entityProducer != null && entityProducer.isRepeatable()) { |
Member
There was a problem hiding this comment.
@JasonMathison Damn. Good catch. However, I propose AsyncEntityProducer#isRepeatable check be dropped here. At this point if the entity producer is not null we should always call AsyncEntityProducer#releaseResources.
…r is not null then always call releaseResrouces() when retrying.
ok2c
pushed a commit
that referenced
this pull request
Jan 5, 2022
JasonMathison
deleted the
HTTPCLIENT-2194_Async_retries_not_including_body
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HTTPCLIENT-2194
We found that our async retries were failing because there was no body being set. Releasing the entityProducer resets the starting point to 0 and resolved the issue for us.