HTTPCLIENT-2263: Cannot Access Trailer-Headers in Chunked transfer-encoding#425
Merged
ok2c merged 2 commits intoapache:4.5.xfrom Mar 16, 2023
Merged
HTTPCLIENT-2263: Cannot Access Trailer-Headers in Chunked transfer-encoding#425ok2c merged 2 commits intoapache:4.5.xfrom
ok2c merged 2 commits intoapache:4.5.xfrom
Conversation
…unked transfer-encoding Implementing getTrailers() in ResponseEntityProxy which will return a Supplier which propagates the output of ChunkedInputStream.getFooters(), otherwise it returns a empty list.
…coding Resolves this issue by cherry-picking fix from HTTPCLIENT-1992 with minor changes for compability with 4.5.x. Implementing getTrailers() in ResponseEntityProxy which which propagates the output of ChunkedInputStream.getFooters(), otherwise it returns a empty list.
ok2c
requested changes
Mar 16, 2023
httpclient/src/main/java/org/apache/http/impl/execchain/ResponseEntityProxy.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is backporting a change which was made to ResponseEntityProxy in v5.0. I understand that the 4.5.x branch is closed to any visible API changes. If these changes fall outside of the scope of what is permissible for this branch please let me know and reject the PR.