Fixed NPE PoolingAsyncClientConnectionManager#82
Closed
carterkozak wants to merge 1 commit intoapache:masterfrom
Closed
Fixed NPE PoolingAsyncClientConnectionManager#82carterkozak wants to merge 1 commit intoapache:masterfrom
carterkozak wants to merge 1 commit intoapache:masterfrom
Conversation
PoolingAsyncClientConnectionManager.validateAfterInactivity causes an NPE when PoolEntries are initially created with no Connection. Added logic to avoid checking the connection on every pool checkout similar to the blocking pool. Added an connection.isOpen check to http1.x connections leased from the pool, although I'm unsure if it's at all effective.
carterkozak
commented
Aug 9, 2017
|
|
||
| }))); | ||
| } else { | ||
| if (!connection.isOpen()) { |
Contributor
Author
There was a problem hiding this comment.
This seems to be half the implementation of the blocking connection isStale() check
Member
There was a problem hiding this comment.
The stale connection check (as an attempt to read from the socket) is only applicable to blocking connections.
asfgit
pushed a commit
that referenced
this pull request
Aug 9, 2017
PoolingAsyncClientConnectionManager.validateAfterInactivity causes an NPE when PoolEntries are initially created with no Connection. Added logic to avoid checking the connection on every pool checkout similar to the blocking pool. Added an connection.isOpen check to http1.x connections leased from the pool, although I'm unsure if it's at all effective. Closes PR #82
Member
|
Please review and close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoolingAsyncClientConnectionManager.validateAfterInactivity causes
an NPE when PoolEntries are initially created with no Connection.
Added logic to avoid checking the connection on every pool
checkout similar to the blocking pool.
Added an connection.isOpen check to http1.x connections leased
from the pool, although I'm unsure if it's at all effective.
NPE stack trace (happens on all requests when
validateAfterInactivityis set):