Merge connect and handshake timeouts in AbstractIOSessionPool#102
Merged
rschmitt merged 1 commit intoapache:masterfrom Jan 25, 2019
rschmitt:master
Merged
Merge connect and handshake timeouts in AbstractIOSessionPool#102rschmitt merged 1 commit intoapache:masterfrom rschmitt:master
rschmitt merged 1 commit intoapache:masterfrom
rschmitt:master
Conversation
This change essentially reverts a portion of 40cae22 that appears to have been unnecessary. Since the `requestTimeout` parameter is always a connection timeout (at least in the client-side code), we don't need to dedicate an additional parameter to the TLS handshake timeout value: we simply use the `requestTimeout` (which has been renamed `connectTimeout` for clarity).
Contributor
Author
|
I'm not very confident about the rename from |
ok2c
approved these changes
Jan 24, 2019
Member
|
@rschmitt |
Contributor
Author
|
I guess you're right. I suppose that makes sense, since this class is pooling sessions and not connections. (It's just a quirk of terminology that we also "connect" to establish a session.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change essentially reverts a portion of 40cae22 that appears to
have been unnecessary. Since the
requestTimeoutparameter is always aconnection timeout (at least in the client-side code), we don't need to
dedicate an additional parameter to the TLS handshake timeout value: we
simply use the
requestTimeout(which has been renamedconnectTimeoutfor clarity).