Add KEEP_ALIVE constant and use existing header for PROXY_AUTHENTICATE.#124
Merged
garydgregory merged 15 commits intoapache:masterfrom May 3, 2019
Merged
Conversation
Update RxJava from 2.2.7 to 2.2.8.
ok2c
approved these changes
May 3, 2019
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@garydgregory Looks OK to me. Please do rebase the branch off master, though. There appear to be unrelated changes from your previous commits in the change-set.
…garydgregory/httpcomponents-core.git into keep_alive_header_plus_cleanups
…garydgregory/httpcomponents-core.git into keep_alive_header_plus_cleanups
ok2c
requested changes
May 3, 2019
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@garydgregory Now the branch is a complete mess. Please do not merge it.
…ATE. - Reuse HeaderElements.CONTINUE.
…garydgregory/httpcomponents-core.git into keep_alive_header_plus_cleanups
Member
Author
|
Why not use GitHub to squash and merge? |
Member
|
@garydgregory I do not understand why you just do not want to rebase your changes off master. Anyway, if you do not want to keep your original commits feel free to squash them and commit your changes to this branch as a single commit. |
Member
Author
|
@ok2c Well, I just messed up the rebase in my fork. No biggie. GH makes it simple here to do a "Squash and merge" in one go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add KEEP_ALIVE constant and use existing header for PROXY_AUTHENTICATE.