Better HttpVersion and ProtocolVersion.#131
Merged
garydgregory merged 1 commit intoapache:masterfrom Jun 15, 2019
Merged
Conversation
ok2c
reviewed
Jun 14, 2019
| * @throws IllegalArgumentException if either major or minor version number is negative | ||
| */ | ||
| @Override | ||
| public ProtocolVersion forVersion(final int major, final int minor) { |
Member
There was a problem hiding this comment.
@garydgregory I think forVersion method should be removed. It not being used anywhere in the productive code and has been rendered superfluous by static get method.
Member
Author
There was a problem hiding this comment.
@ok2c I force pushed to remove the methods and another tweak.
Remove forVersion methods and refactor to avoid duplicate code.
garydgregory
force-pushed
the
better_http_version
branch
from
83cc47b to
61ec2d0
Compare
ok2c
approved these changes
Jun 15, 2019
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@garydgregory Looks good to me. Please do try to make sure there is nothing missing before merging to avoid follow-up commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.