HTTPCORE-599#148
Merged
Merged
Conversation
…ead of the underlying network channel
…k channel of READ interest is disabled
Member
Author
|
@rhernandez35 @rschmitt @rhashimoto The fix itself is a trivial one liner: 84b0014 but I had to tweak |
Contributor
|
@ok2c Looks okay to me, as long as this won't affect use cases like detecting closed connections and TCP RSTs. |
Member
Author
|
@rschmitt Half-closed connections should not be problem but TCP RST indeed might. I am now very tempted to start a major rewrite of the buffering logic in the TLS/SSL layer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.