Clean up connection window management#176
Merged
rschmitt merged 2 commits intoapache:masterfrom Dec 29, 2019
rschmitt:conn-window
Merged
Clean up connection window management#176rschmitt merged 2 commits intoapache:masterfrom rschmitt:conn-window
rschmitt merged 2 commits intoapache:masterfrom
rschmitt:conn-window
Conversation
This commit implements the following changes to input window management: 1. The `lowMark` is set according to local settings, not remote settings 2. The connection window is set to `Integer.MAX_VALUE` during `SETTINGS` exchange 3. The connection window low mark is now a constant value (10 MiB) 4. The input window update code in `onOutput` has been removed
ok2c
approved these changes
Dec 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the following changes to input window management:
lowMarkis set according to local settings, not remote settingsInteger.MAX_VALUEduringSETTINGSexchangeonOutputhas been removed