Skip to content

[HTTPCORE-623] BHttpConnection#isDataAvailable int -> Timeout #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garydgregory merged 1 commit into from
Jan 15, 2020
Merged

[HTTPCORE-623] BHttpConnection#isDataAvailable int -> Timeout #185

garydgregory merged 1 commit into from
Jan 15, 2020

Conversation

@garydgregory
Copy link
Member

@garydgregory garydgregory commented Jan 12, 2020

michael-o
michael-o requested changes Jan 12, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rebase against master first.

michael-o
michael-o approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now requires a rebase first.

@garydgregory
Copy link
Member Author

garydgregory commented Jan 12, 2020 •
edited
Loading

This looks good now requires a rebase first.

I think we can just do a squash and merge from here.

@michael-o
Copy link
Member

michael-o commented Jan 12, 2020

This looks good now requires a rebase first.

I think we can just do a squash and merge from here.

Don't do this, even if GH allowed. I have seem to many failures from this automated process. It says "conflicts" anyway. Please fix this in Git Bash.

@garydgregory garydgregory force-pushed the HTTPCORE-623_BHttpConnection_isDataAvailable() branch from 48530dc to 9f3245c Compare January 14, 2020 20:56
@garydgregory
[HTTPCORE-623] Change
68e16f0 
org.apache.hc.core5.http.io.BHttpConnection.isDataAvailable() int input
to Timeout.
@garydgregory garydgregory reopened this Jan 14, 2020
@garydgregory
Copy link
Member Author

garydgregory commented Jan 14, 2020

@michael-o done.

@garydgregory garydgregory changed the title Httpcore 623 b http connection is data available() [HTTPCORE-623] b http connection is data available() Jan 14, 2020
@garydgregory garydgregory changed the title [HTTPCORE-623] b http connection is data available() [HTTPCORE-623] BHttpConnection#isDataAvailable int -> Timeout Jan 14, 2020
@garydgregory garydgregory merged commit 529b392 into apache:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garydgregory @michael-o