HTTPCORE-639: Partially revert expensive early-response checks#210
Closed
carterkozak wants to merge 3 commits intoapache:masterfrom
Closed
HTTPCORE-639: Partially revert expensive early-response checks#210carterkozak wants to merge 3 commits intoapache:masterfrom
carterkozak wants to merge 3 commits intoapache:masterfrom
Conversation
This reverts commit d2afcc6.
This patch mostly restores the behavior of hc 4.x releases in which large early responses can result in the client blocking until a socket exception is thrown. Behavior of plain http detection is not modified, but only works prior to jre13 due to http://openjdk.java.net/jeps/353. This behavior will be configurable in 5.1 releases, but has been removed as the result of a request entity performance regression that limited any request to at minimum a full millisecond and at most 8 MiB/second upload speed regardless of the network.
Member
|
I am not convinced that this is a good idea. It should either work consistently accross protocols or nothing at all. |
Contributor
Author
|
I'm conflicted about the backport. On one hand It's helpful to minimize impact in bugfix releases, if we can avoid changing behavior for users without TLS, that could be helpful. On the other hand I agree that it's confusing to support this feature in some non-obvious configurations, it's common to run tests without ssl and we wouldn't want to create a false sense of security. |
Member
|
I think we have tests for TLS too since ALPN is tested. We can consider the implementation in 5.0.x after this PR as naive as for the SHOULD in the RFC. No guarantees made. |
Contributor
Author
|
Thanks, I'm closing this because a3870ef has been committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch mostly restores the behavior of hc 4.x releases in
which large early responses can result in the client blocking until
a socket exception is thrown. Behavior of plain http detection
is not modified, but only works prior to jre13 due to
http://openjdk.java.net/jeps/353.
This behavior will be configurable in 5.1 releases, but has been
removed as the result of a request entity performance regression
that limited any request to at minimum a full millisecond and at
most 8 MiB/second upload speed regardless of the network.