HTTPCLIENT-1916: Add URIBuilder.removeParameter

[peterdettman]

https://issues.apache.org/jira/browse/HTTPCLIENT-1916 .

Note that I have marked the new method as "since 5.2".

[garydgregory]

May you please test edge cases like null and ""?

[peterdettman]

I'm happy to add such tests, but I'm a bit unclear what the expected behaviour ought to be. I'm inclined to require non-null, non-empty for param but actually other URIBuilder methods don't seem to exclude "" for a name (is that really permissible?). BasicNameValuePair guards only against null too).

[michael-o]

Why is a remove method necessary in a builder? Coming from a pre-built URI?

[peterdettman]

@michael-o Some rationale was given by the submitter; I am merely picking up a volunteers-wanted label.

[ok2c]

I'm happy to add such tests, but I'm a bit unclear what the expected behaviour ought to be. I'm inclined to require non-null, non-empty for param but actually other URIBuilder methods don't seem to exclude "" for a name (is that really permissible?). BasicNameValuePair guards only against null too).

@peterdettman I think just null check should be enough for now. The issue of name/value pairs with an empty name should be dealt with consistently across the entire library.

[peterdettman]

I've added a null guard for the argument, with accompanying test.