Skip to content

Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutputStream() calls respectively.#386

Closed
arturobernalg wants to merge 1 commit into
apache:5.3.xfrom
arturobernalg:feature/newStream
Closed

Replace new FileInputStream() and/or new FileOutputStream() expressions with Files.newInputStream() and/or Files.newOutputStream() calls respectively.#386
arturobernalg wants to merge 1 commit into
apache:5.3.xfrom
arturobernalg:feature/newStream

Conversation

@arturobernalg
Copy link
Copy Markdown
Member

@arturobernalg arturobernalg commented Feb 5, 2023

Again, this could be a matter of taste.

@ok2c
Copy link
Copy Markdown
Member

ok2c commented Feb 8, 2023

@arturobernalg 1. Please change the target branch to 5.3.x. 2. I see 2 more instances of new File*Stream. Please replace them as well.

@arturobernalg arturobernalg force-pushed the feature/newStream branch 2 times, most recently from c02f91d to 9c904ad Compare February 8, 2023 20:00
@arturobernalg arturobernalg changed the base branch from master to 5.3.x February 8, 2023 20:00
@arturobernalg
Replace new FileInputStream() and/or new FileOutputStream() expressio…
d874086 
…ns with Files.newInputStream() and/or Files.newOutputStream() calls respectively.
@arturobernalg
Copy link
Copy Markdown
Member Author

arturobernalg commented Feb 8, 2023

@arturobernalg 1. Please change the target branch to 5.3.x. 2. I see 2 more instances of new File*Stream. Please replace them as well.

@ok2c Done

@ok2c
Copy link
Copy Markdown
Member

ok2c commented Feb 9, 2023

@arturobernalg I am sorry I only now realized that the new APIs work with Path values and therefore entail an overhead of an extra conversion from File to Path. I do not think it is worth it. I am sorry I have asked you to do extra work.

@arturobernalg
Copy link
Copy Markdown
Member Author

arturobernalg commented Feb 10, 2023

@arturobernalg I am sorry I only now realized that the new APIs work with Path values and therefore entail an overhead of an extra conversion from File to Path. I do not think it is worth it. I am sorry I have asked you to do extra work.

sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturobernalg @ok2c