Return emptySet or emptyList instead of null to honor contract for re…#398
Merged
ok2c merged 1 commit intoapache:5.3.xfrom Mar 27, 2023
Merged
Conversation
Member
|
Should the collection returned be editable? |
Contributor
Author
|
Majority of the changes proposed here are around method getTrailerNames() in EntityDetails interface. There are many places where we are already returning immutable collection i.e. emptySet for implementation of this method. I believe that is what is correct. But few places were returning null. This PR fixes those issues. |
Member
|
@sandeepnkulkarni Please change the target branch to 5.3.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…turn type