4.4.5 why the httpcore-nio release conn is before the request future is done, this may trigger request be canceled, this lead to request future don't get the result but really the response is return.

[gavenpeng]

I am use httpcore-nio found a strange problem, the request is very faster,bu no get the result,I read the code,has the follow problem.

while http request response complete, the reactor io thread then set request consumer is complete, the http reactor io thread to invoke the completed method of the RequestExecutionCallback,the follower is code:

public void completed(final T result) {
try {
this.connPool.release(this.poolEntry, true);
} finally {
this.future.completed(result);
}
}

the connPool.release method need get the lock, release lock after and process the leasing request, if blocked while get the lock then the request future complete is delay, this may be trigger the tomcat thread found the handler is done but the request future is no done, lead to cancel the request ,no return result,but really is the request response is return; the code is :
private void initExecution(
final HttpAsyncClientExchangeHandler handler, final NHttpClientConnection conn) {

    final HttpContext context = conn.getContext();
    synchronized (context) {
        context.setAttribute(HttpAsyncRequestExecutor.HTTP_HANDLER, handler);
        if (!conn.isOpen()) {
            handler.failed(new ConnectionClosedException("Connection closed"));
        } else {
            //唤醒IO线程,开始发送请求
            conn.requestOutput();
        }
    }     
    //the request consumer is complete,
    if (handler.isDone()) {
        try {
            handler.close();
        } catch (final IOException ex) {
            log(ex);
        }
    }
}

I also have a problem about the method of initExecution,why need the synchronized the context, the context is
bind with conn, the conn is hold by only one thread.please help me ,thanks

[ok2c]

Could you please update your PR to include only those changes you would like to be incorporated into the project? At the moment your PR pulls 143 commits and changes 314 files.

[garydgregory]

Probably an EOL thing...

…

On Wed, May 24, 2017 at 12:41 PM, Oleg Kalnichevski < ***@***.***> wrote: Could you please update your PR to include only those changes you would like to be incorporated into the project? At the moment your PR pulls 143 commits and changes 314 files. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIfN2q-ZDPdoWuwC2vrpZdZr-mVbTFVks5r9IfwgaJpZM4NhfRW> .

-- E-Mail: garydgregory@gmail.com | ggregory@apache.org Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory

[ok2c]

@gavenpeng If you are unwilling to update the PR could you please close it?

[gavenpeng]

closed

[ok2c]

@gavenpeng Could you please close this pull request?

[gmcdonald]

All done here.