Bug fix: Classic RequestListener to continue accepting incoming connections in case of an unexpected exception caused by a single connection #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection creation or in worker execution
ok2c
changed the title
Member
|
@cdw8j Cherry-picked to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RequestListener thread terminates when an exception occurs during connection creation or in the worker thread. Specifically, I have noticed this issue simply when an http connection is attempted to an HttpServer with SSLContext - the server essentially terminates.
So instead of throwing the corresponding exception, it should be handled by the application's exceptionListener.
(This is also how it was implemented in httpcore4.)