HTTP/2: handle zero WINDOW_UPDATE increment#634
Merged
arturobernalg merged 1 commit intoapache:masterfrom Feb 23, 2026
Merged
Conversation
ok2c
approved these changes
Feb 22, 2026
Treat WINDOW_UPDATE with a window size increment of 0 as PROTOCOL_ERROR. Apply stream error semantics for stream windows and connection error semantics for stream 0, as required by RFC 9113.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat WINDOW_UPDATE frames with a window size increment of 0 according to RFC 9113 by applying stream error semantics for stream flow-control windows and connection error semantics for stream 0.
RFC 9113 6.9
(WINDOW_UPDATE): “A receiver MUST treat the receipt of a WINDOW_UPDATE frame with a flow-control window increment of 0 as a stream error (Section 5.4.2) of type PROTOCOL_ERROR; errors on the connection flow-control window MUST be treated as a connection error (Section 5.4.1).”